Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update getLanguageString functions #515

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

peterstadler
Copy link
Member

and add tests. This will avoid function errors due to returning empty sequence instead of strings.

In fact, this is a replacement for #511 which our Kleingruppe considered only a workaround.
Refs #502

How Has This Been Tested?

By adding tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement
  • Refactoring

Overview

  • I have updated the inline documentation accordingly.
  • I have performed a self-review of my code, according to the style guide
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes at testing
  • All new and existing tests passed.

and add tests. This will avoid function errors due to returning empty sequence instead of strings.

Co-Authored-By: Daniel Jettka <[email protected]>
Co-Authored-By: Daniel Röwenstrunk <[email protected]>
Co-Authored-By: krHERO <[email protected]>
@peterstadler peterstadler linked an issue Jan 7, 2025 that may be closed by this pull request
@peterstadler peterstadler added this to the 1.0.0 milestone Jan 7, 2025
@roewenstrunk roewenstrunk self-requested a review January 7, 2025 14:11
Copy link
Member

@roewenstrunk roewenstrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test are running. Perfect

@roewenstrunk roewenstrunk merged commit 22b7859 into develop Jan 7, 2025
4 of 5 checks passed
@roewenstrunk roewenstrunk deleted the update-getLanguage-Functions branch January 7, 2025 14:31
@roewenstrunk roewenstrunk restored the update-getLanguage-Functions branch January 7, 2025 14:33
@peterstadler peterstadler deleted the update-getLanguage-Functions branch January 7, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] getParts.xql fails if part-names can't be translated
2 participants