Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Context and related Issue
When adding an edition file as test data to the testing/XQsuite/data collection the Edirom would automatically pick up this "edition". This PR rewrites the functions for finding (all) editions from the database (formerly
edition:getUris#0
, nowedition:findEditionUris#0
) and the function for retrieving (just) one edition by its ID or database path (formerlyedition:findEdition#1
, nowedition:getEditionURI#1
).The notable difference of
edition:getEditionURI#1
is that it now will return the empty sequence if no resolvable edition ID or path is provided. It will not magically search the whole database. If this is intended, you'll need to combine this withedition:findEditionUris#0
. Seeindex.xql
where this change got necessary.How Has This Been Tested?
Tested locally with the clarinet quintet and the Pintos data.
Types of changes
Overview