Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep avatar images in one row #190

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

peterstadler
Copy link
Member

so they are still having the full height

@peterstadler
Copy link
Member Author

A bit more explanation and thoughts:
The current linebreak (before the last avatar icon) occurs because of the default setting of contrib.rocks which is 12. See available options:

max={number} 
  Max contributor count (100 by default)
columns={number} 
  Max columns (12 by default)
anon={0|1}
  Include anonymous users (false by default)

We might add max and set it to the same value as columns to prevent a linebreak completely, on the other hand I think I prefer a linebreak over hiding new contributors.
That said, we could probably set columns to a much higher value than 20 (as I set it now) to be future proof. Or we could react to it accordingly when we hit the limit of 20 …

Copy link

@daniel-jettka daniel-jettka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think columns=20 is a good solution. It is in a way also future-proof in that it will be easily visible if the number of contributors exceeds 20 and now that the parameter is in the code it is easy to increase it. And if there are more than 20 contributors one day someone will be able to do that :-)

@daniel-jettka daniel-jettka merged commit 8c571f4 into develop Jan 2, 2024
6 checks passed
@daniel-jettka daniel-jettka deleted the augment-avatar-image branch January 2, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants