Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch files reorganization #13

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

JCarosella
Copy link
Collaborator

Closes #12

@JCarosella JCarosella force-pushed the launch-files-reorganization branch from 667b161 to 05df471 Compare October 31, 2022 13:18
@francocipollone
Copy link
Collaborator

I would still call it noah_gazebo instead of noah_simulation. Why? Because:

  1. In general it is how I've seen it out there: e.g.: https://github.com/ros-mobile-robots/diffbot
  2. It is scalable: Let's say that we want to create an ignition simulation, we simply add a noah_ignition folder.

@JCarosella
Copy link
Collaborator Author

I would still call it noah_gazebo instead of noah_simulation. Why? Because:

  1. In general it is how I've seen it out there: e.g.: https://github.com/ros-mobile-robots/diffbot
  2. It is scalable: Let's say that we want to create an ignition simulation, we simply add a noah_ignition folder.

Well, that makes sense. In my head instead of adding another package I was thinking in adding another branch, but if the simulators both use ROS it makes sense to just add another package here.

I'll roll back the change, which should remove a ton of diffs. Let's hold the review until that is done

@JCarosella
Copy link
Collaborator Author

@francocipollone Rolled back to noah_gazebo package name.Ready for review again.

I also removed the pictures of people from the small_house world

@JCarosella JCarosella changed the title Draft: Launch files reorganization Launch files reorganization Nov 1, 2022
@francocipollone francocipollone removed their request for review May 21, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Re-organize launchfiles for a cleaner stack
3 participants