Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_optimization_with_linear_constraint in integration tests is flaky. #421

Closed
mmahsereci opened this issue Jun 1, 2022 · 7 comments
Closed

Comments

@mmahsereci
Copy link
Contributor

Test fails about 50% of the time due to infs or nans.

integration_tests/emukit/bayesian_optimization/test_constrained_loop.py::test_optimization_with_linear_constraint

@apaleyes
Copy link
Collaborator

I can confirm that it's a bit flacky, but not nearly as bad as 50% for me. Running this test locally, it fails once every 20 runs or so. Is that worse for you @mmahsereci ?

@apaleyes
Copy link
Collaborator

Starting to suspect this might be related to #291

@mmahsereci
Copy link
Contributor Author

I can confirm that it's a bit flacky, but not nearly as bad as 50% for me. Running this test locally, it fails once every 20 runs or so. Is that worse for you @mmahsereci ?

It failed repeatedly during my last PRs which was quite annoying. If I had to guess it was more often than every 20 times. Did not try locally.

@apaleyes apaleyes mentioned this issue Jun 22, 2022
@mmahsereci
Copy link
Contributor Author

mmahsereci commented Aug 5, 2022

It seems that there are two more tests failing now. These ones do not seem to be simply flaky but there are some shape and index errors.

  • tests/emukit/bayesian_optimization/test_bayesian_optimization_loop.py::test_loop[3]
  • tests/emukit/bayesian_optimization/test_local_penalization_calculator.py::test_local_penalization

See e.g.,
https://github.com/EmuKit/emukit/runs/7689362107?check_suite_focus=true

@mmahsereci
Copy link
Contributor Author

Perhaps it's due to scipy again. They released version 1.9.0 some days ago and the failed tests seem to be using it while the tests that pass use an older version

https://docs.scipy.org/doc/scipy/release.1.9.0.html

@apaleyes
Copy link
Collaborator

apaleyes commented Sep 2, 2022

It was scipy indeed. Some explanation is in the fixing PR. Tests should be passing again!

@mmahsereci
Copy link
Contributor Author

Closing since it should be fixed by #437 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants