Fix scipy again #433
Merged
Fix scipy again #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #433 +/- ##
=======================================
Coverage 89.15% 89.15%
=======================================
Files 136 136
Lines 4703 4703
Branches 681 681
=======================================
Hits 4193 4193
Misses 393 393
Partials 117 117
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Nice, thanks! So weird, the bug seems to have been there since the begging. |
|
There is a warning about it in scipy that promises "i'll turn into an error after 1.11.0, fix me!". Well, 8 releases later it finally delivered on that promise. Could be that we ignored it all that time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #421
Description of changes: Scipy minimize expects 1d inputs, and we were passing 2d for some unclear reason. Best part is that we were doing it intentionally, for no other reason, so the fix is just to remove a few symbols. Nice!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.