-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding python script to easily obtain key customer info #41
base: main
Are you sure you want to change the base?
Conversation
Runs commands in command line, conducts string manipulation to obtain key pieces of infromation, and saves to results file
@sarahraza007 please update your branch to fix the CI errors. From your working branch, run |
@sarahraza007 Thank you! |
Please, move the files you are working on to |
@sarahraza007 just one final note before we consider merging this PR. Please add a
Add more content as needed. |
Good job @sarahraza007 !
Please, also update your branch with: git fetch
git merge origin/main |
…eperate yaml files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality and information wise, this looks great so far!!
There is one case I am curious about - do we need to account for build options that users might pass to the Bazel CLI? For example, I might run a build with certain configurations and flags: bazel build //this/is/an:example --config=remote --incompatible_strict_action_env ...
I'm thinking we can provide a list build_options
that the end user would populate before running the script. This list would then be passed to bazel cquery
when we call it (cquery
should support build options). Let me know your thoughts.
//java/...: | ||
- ' BazelJavaProtoAspect: 3' | ||
- '' | ||
'Configurations:': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be really curious to see what this section looks like when the script is ran in another repo; details like darwin_amd64
in Execution Platforms
are very helpful but the Configurations
section seems a bit redundant in this example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we check this in? |
Co-authored-by: Andrés Felipe Barco Santa <[email protected]>
Co-authored-by: Andrés Felipe Barco Santa <[email protected]>
Co-authored-by: Andrés Felipe Barco Santa <[email protected]>
Moving this to Ready for review. |
I've asked @vaibhav-shah to take over this and find a good place for this to live as a sales tool |
Do we reached a decision on where to put this? |
Runs commands in command line, conducts string manipulation to obtain key pieces of infromation, and saves to results file