-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move actuary contacts section to rate details page (#2365)
* WIP: moved actuary radio group * form validation * removal from contacts page * added flexibility to span * added addtlActuaryContacts * dynamic addtnlActuaryContacts form working wip * testing * removed old tests * test fixes * removing unneeded work after pivoting back to dynamic functionality * removed cypress tests * cypress fixes * more test fixes * v1 ratedetails * moved comms preference, still need to follow up with fixing tests * v2 test fixes * v1 test fixes * test fix * test fixes * something isnt working here WIP * cypress fixes * updating test * cypress fixes * Update protobuffer functions for rate additl actuary workaround. Update zod. * Only save addtl actuaries at the rate level. * Update API and helpers with rate level addtl actuaries workaround. * Use addtlActuaryContacts from rate data. * Display addtl actuaries from rate level. * Update for addtl actuary change. * test fix * small fix for cypress * A comment * Another comment --------- Co-authored-by: Jason Lin <[email protected]> Co-authored-by: MacRae Linton <[email protected]>
- Loading branch information
1 parent
f58aa97
commit b02ef4f
Showing
43 changed files
with
1,000 additions
and
919 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -169,6 +169,14 @@ describe('convertHealthPlanPackageRatesToDomain', () => { | |
email: '[email protected]', | ||
}, | ||
], | ||
addtlActuaryContacts: [ | ||
{ | ||
actuarialFirm: 'DELOITTE', | ||
name: 'Additional Actuary Contact', | ||
titleRole: 'Test Additional Actuary Contact', | ||
email: '[email protected]', | ||
}, | ||
], | ||
actuaryCommunicationPreference: 'OACT_TO_ACTUARY', | ||
packagesWithSharedRateCerts: [], | ||
}, | ||
|
@@ -199,6 +207,14 @@ describe('convertHealthPlanPackageRatesToDomain', () => { | |
email: '[email protected]', | ||
}, | ||
], | ||
addtlActuaryContacts: [ | ||
{ | ||
actuarialFirm: 'DELOITTE', | ||
name: 'Additional Actuary Contact', | ||
titleRole: 'Test Additional Actuary Contact', | ||
email: '[email protected]', | ||
}, | ||
], | ||
actuaryCommunicationPreference: 'OACT_TO_ACTUARY', | ||
packagesWithSharedRateCerts: [ | ||
{ | ||
|
@@ -217,15 +233,8 @@ describe('convertHealthPlanPackageRatesToDomain', () => { | |
}, | ||
], | ||
stateContacts: [], | ||
addtlActuaryContacts: [], | ||
addtlActuaryCommunicationPreference: 'OACT_TO_ACTUARY', | ||
addtlActuaryContacts: [ | ||
{ | ||
actuarialFirm: 'DELOITTE', | ||
name: 'Additional Actuary Contact', | ||
titleRole: 'Test Actuary Contact', | ||
email: '[email protected]', | ||
}, | ||
], | ||
statutoryRegulatoryAttestation: false, | ||
statutoryRegulatoryAttestationDescription: 'No compliance', | ||
} | ||
|
@@ -258,12 +267,11 @@ describe('convertHealthPlanPackageRatesToDomain', () => { | |
], | ||
actuaryCommunicationPreference: 'OACT_TO_ACTUARY', | ||
packagesWithSharedRateCerts: [], | ||
// Additional actuaries from package should be in each rate now. | ||
addtlActuaryContacts: [ | ||
{ | ||
actuarialFirm: 'DELOITTE', | ||
name: 'Additional Actuary Contact', | ||
titleRole: 'Test Actuary Contact', | ||
titleRole: 'Test Additional Actuary Contact', | ||
email: '[email protected]', | ||
}, | ||
], | ||
|
@@ -308,7 +316,7 @@ describe('convertHealthPlanPackageRatesToDomain', () => { | |
{ | ||
actuarialFirm: 'DELOITTE', | ||
name: 'Additional Actuary Contact', | ||
titleRole: 'Test Actuary Contact', | ||
titleRole: 'Test Additional Actuary Contact', | ||
email: '[email protected]', | ||
}, | ||
], | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -259,6 +259,8 @@ describe(`Tests unlockHealthPlanPackage`, () => { | |
email: '[email protected]', | ||
actuarialFirm: 'MERCER', | ||
}, | ||
], | ||
addtlActuaryContacts: [ | ||
{ | ||
name: 'Enrico Soletzo 2', | ||
titleRole: 'person', | ||
|
@@ -383,8 +385,14 @@ describe(`Tests unlockHealthPlanPackage`, () => { | |
finallySubmittedFormData.rateInfos[0].actuaryContacts.map( | ||
(c) => c.name | ||
) | ||
expect(actuariesInOrder).toEqual([ | ||
'Enrico Soletzo 1', | ||
expect(actuariesInOrder).toEqual(['Enrico Soletzo 1']) | ||
|
||
// checks additional actuaries in order | ||
const addtlActuariesInOrder = | ||
finallySubmittedFormData.rateInfos[0].addtlActuaryContacts?.map( | ||
(c) => c.name | ||
) | ||
expect(addtlActuariesInOrder).toEqual([ | ||
'Enrico Soletzo 2', | ||
'Enrico Soletzo 3', | ||
]) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -224,23 +224,28 @@ describe(`Tests UpdateHealthPlanFormData`, () => { | |
|
||
// update that draft form data. | ||
const formData = Object.assign(latestFormData(createdDraft), { | ||
addtlActuaryContacts: [ | ||
rateInfos: [ | ||
{ | ||
name: 'additional actuary 1', | ||
titleRole: 'additional actuary title 1', | ||
email: '[email protected]', | ||
actuarialFirm: 'MERCER' as const, | ||
actuarialFirmOther: '', | ||
}, | ||
{ | ||
name: 'additional actuary 2', | ||
titleRole: 'additional actuary title 2', | ||
email: '[email protected]', | ||
actuarialFirm: 'MERCER' as const, | ||
actuarialFirmOther: '', | ||
...rate1, | ||
addtlActuaryContacts: [ | ||
{ | ||
name: 'additional actuary 1', | ||
titleRole: 'additional actuary title 1', | ||
email: '[email protected]', | ||
actuarialFirm: 'MERCER' as const, | ||
actuarialFirmOther: '', | ||
}, | ||
{ | ||
name: 'additional actuary 2', | ||
titleRole: 'additional actuary title 2', | ||
email: '[email protected]', | ||
actuarialFirm: 'MERCER' as const, | ||
actuarialFirmOther: '', | ||
}, | ||
], | ||
}, | ||
rate2, | ||
], | ||
rateInfos: [rate1, rate2], | ||
}) | ||
|
||
// convert to base64 proto | ||
|
@@ -284,6 +289,18 @@ describe(`Tests UpdateHealthPlanFormData`, () => { | |
packageName: packageWithSharedRate2.packageName, | ||
}), | ||
]), | ||
addtlActuaryContacts: expect.arrayContaining([ | ||
expect.objectContaining({ | ||
name: 'additional actuary 1', | ||
titleRole: 'additional actuary title 1', | ||
email: '[email protected]', | ||
}), | ||
expect.objectContaining({ | ||
name: 'additional actuary 2', | ||
titleRole: 'additional actuary title 2', | ||
email: '[email protected]', | ||
}), | ||
]), | ||
}), | ||
expect.objectContaining({ | ||
...rate2, | ||
|
Oops, something went wrong.