test fixes

Enterprise-CMCS · Apr 16, 2024 · caa1eb8 · caa1eb8
1 parent 35fbdfb
commit caa1eb8
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 2 deletions.
diff --git a/services/app-web/src/formHelpers/formatters.ts b/services/app-web/src/formHelpers/formatters.ts
@@ -40,6 +40,29 @@ function formatForForm<T> (
 
 // This function can be cleaned up when we move off domain types and only use graphql
 const formatActuaryContactsForForm = (actuaryContacts?: ActuaryContact[] | GQLActuaryContact[]) : ActuaryContact[] => {
+    return actuaryContacts &&  actuaryContacts.length > 0
+        ? actuaryContacts.map( (contact) => {
+            const {name, titleRole,email,actuarialFirm, actuarialFirmOther} = contact
+                    return {
+                    name: name ?? '',
+                    titleRole: titleRole ?? '',
+                    email: email ?? '',
+                    actuarialFirmOther: actuarialFirmOther ?? undefined,
+                    actuarialFirm: actuarialFirm ?? undefined,
+                }
+        })
+        : [
+              {
+                  name: '',
+                  titleRole: '',
+                  email: '',
+                  actuarialFirm: undefined,
+                  actuarialFirmOther: '',
+              },
+          ]
+}
+
+const formatAddtlActuaryContactsForForm = (actuaryContacts?: ActuaryContact[] | GQLActuaryContact[]) : ActuaryContact[] => {
     return actuaryContacts &&  actuaryContacts.length > 0
         ? actuaryContacts.map( (contact) => {
             const {name, titleRole,email,actuarialFirm, actuarialFirmOther} = contact
@@ -199,6 +222,7 @@ export {
     formatDocumentsForDomain,
     formatDocumentsForForm,
     formatActuaryContactsForForm,
+    formatAddtlActuaryContactsForForm,
     formatDocumentsForGQL,
     formatFormDateForGQL
 }
diff --git a/services/app-web/src/pages/StateSubmission/RateDetails/V2/SingleRateFormFields.tsx b/services/app-web/src/pages/StateSubmission/RateDetails/V2/SingleRateFormFields.tsx
@@ -497,7 +497,7 @@ export const SingleRateFormFields = ({
             <FormGroup>
                 <ActuaryContactFields
                     shouldValidate={shouldValidate}
-                    fieldNamePrefix={`${fieldNamePrefix}.actuaryContacts.${index}`}
+                    fieldNamePrefix={`${fieldNamePrefix}.actuaryContacts.0`}
                     fieldSetLegend="Certifying Actuary"
                 />
                 <FieldArray name={`${fieldNamePrefix}.addtlActuaryContacts`}>

diff --git a/services/app-web/src/pages/StateSubmission/RateDetails/V2/rateDetailsHelpers.ts b/services/app-web/src/pages/StateSubmission/RateDetails/V2/rateDetailsHelpers.ts
@@ -1,5 +1,6 @@
 import {
     formatActuaryContactsForForm,
+    formatAddtlActuaryContactsForForm,
     formatDocumentsForForm,
     formatDocumentsForGQL,
     formatForForm,
@@ -93,7 +94,7 @@ const convertGQLRateToRateForm = (getKey: S3ClientT['getKey'], rate?: Rate): For
         actuaryContacts: formatActuaryContactsForForm(
             rateForm?.certifyingActuaryContacts
         ),
-        addtlActuaryContacts: formatActuaryContactsForForm(
+        addtlActuaryContacts: formatAddtlActuaryContactsForForm(
             rateForm?.certifyingActuaryContacts
         ),
         actuaryCommunicationPreference: