Skip to content

Commit

Permalink
Merge branch 'jl-mcr-4663-cms-and-state-sees-a-withdrawn-tag-on-the-s…
Browse files Browse the repository at this point in the history 
…ubmission-summary' into jl-mcr-4664-state-cannot-edit-withdrawn-rates-on-unlocked-submissions

Merge in jl-mcr-4663-cms-and-state-sees-a-withdrawn-tag-on-the-submission-summary
  • Loading branch information
@JasonLin0991
JasonLin0991 committed Jan 10, 2025
2 parents cb13fba + 0976250 commit f4c62c0
Show file tree
Hide file tree
Showing 2 changed files with 170 additions and 9 deletions.
136 changes: 133 additions & 3 deletions services/app-web/src/pages/StateSubmission/ReviewSubmit/RateDetailsSummarySection.test.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,6 @@ describe('RateDetailsSummarySection', () => {
// Is this the best way to check that the link is not present?
expect(screen.queryByText('Edit')).not.toBeInTheDocument()

//expects loading button on component load
expect(screen.getByText('Loading')).toBeInTheDocument()

// expects download all button after loading has completed
await waitFor(() => {
expect(
Expand Down Expand Up @@ -1253,6 +1250,7 @@ describe('RateDetailsSummarySection', () => {
).toBeInTheDocument()
})
})

it('displays deprecated fields on previous submissions viewed by state users', async () => {
vi.spyOn(
usePreviousSubmission,
Expand Down Expand Up @@ -1301,6 +1299,7 @@ describe('RateDetailsSummarySection', () => {
screen.findByText('Programs this rate certification covers')
).toBeTruthy()
})

it('does not display deprecated fields on unlocked submissions for state users', async () => {
const draftContract = mockContractPackageDraft()
if (
Expand Down Expand Up @@ -1333,4 +1332,135 @@ describe('RateDetailsSummarySection', () => {
screen.queryByText('Programs this rate certification covers')
).toBeNull()
})

it('displays withdrawn rates', async () => {
const contractWithWithdrawnRates = mockContractPackageSubmitted({
withdrawnRates: [
{
id: '1234',
webURL: 'https://testmcreview.example/rates/1234',
createdAt: new Date('01/01/2021'),
updatedAt: new Date('01/01/2021'),
status: 'SUBMITTED',
reviewStatus: 'WITHDRAWN',
consolidatedStatus: 'WITHDRAWN',
state: mockMNState(),
stateCode: 'MN',
stateNumber: 5,
parentContractID: 'test-abc-123',
revisions: [],
packageSubmissions: [
{
cause: 'CONTRACT_SUBMISSION',
submitInfo: {
updatedAt: new Date('01/01/2021'),
updatedBy: {
email: '[email protected]',
familyName: 'Hotman',
givenName: 'Zuko',
role: 'CMS_USER',
},
updatedReason: 'Test reason',
},
contractRevisions: [],
rateRevision: {
id: '1234',
rateID: '5678',
createdAt: new Date('01/01/2021'),
updatedAt: new Date('01/01/2021'),
formData: {
rateType: 'NEW',
rateCapitationType: 'RATE_CELL',
rateDocuments: [
{
s3URL: 's3://foo/bar/rate',
name: 'rate docs test 1',
sha256: 'fakesha',
dateAdded: new Date(),
},
],
supportingDocuments: [],
rateDateStart: new Date('01/01/2021'),
rateDateEnd: new Date('12/31/2021'),
rateDateCertified: new Date('12/31/2020'),
amendmentEffectiveDateStart: new Date(
'01/01/2021'
),
amendmentEffectiveDateEnd: new Date(
'12/31/2021'
),
rateCertificationName:
'WITHDRAWN-RATE-NAME',
rateProgramIDs: [
'abbdf9b0-c49e-4c4c-bb6f-040cb7b51cce',
],
deprecatedRateProgramIDs: [],
consolidatedRateProgramIDs: [
'abbdf9b0-c49e-4c4c-bb6f-040cb7b51cce',
],
certifyingActuaryContacts: [
{
actuarialFirm: 'DELOITTE',
name: 'Jimmy Jimerson',
titleRole: 'Certifying Actuary',
email: '[email protected]',
},
],
addtlActuaryContacts: [
{
actuarialFirm: 'DELOITTE',
name: 'Additional actuary',
titleRole: 'Test Actuary Contact 1',
email: '[email protected]',
},
],
actuaryCommunicationPreference:
'OACT_TO_ACTUARY',
packagesWithSharedRateCerts: [],
},
},
submittedRevisions: [],
},
],
},
],
})

renderWithProviders(
<RateDetailsSummarySection
contract={contractWithWithdrawnRates}
submissionName="MN-MSHO-0003"
statePrograms={statePrograms}
/>,
{
apolloProvider: apolloProviderCMSUser,
}
)

expect(
screen.getByRole('heading', {
level: 2,
name: 'Rate details',
})
).toBeInTheDocument()
// Is this the best way to check that the link is not present?
expect(screen.queryByText('Edit')).not.toBeInTheDocument()

// expects download all button after loading has completed
await waitFor(() => {
expect(
screen.getByRole('link', {
name: 'Download all rate documents',
})
).toBeInTheDocument()
})

// expect withdrawn rate to be on the screen
expect(
screen.getByRole('heading', {
level: 3,
name: /WITHDRAWN-RATE-NAME/,
})
).toBeInTheDocument()
})
})
43 changes: 37 additions & 6 deletions services/app-web/src/pages/StateSubmission/ReviewSubmit/RateDetailsSummarySection.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ import { useParams } from 'react-router-dom'
import { LinkWithLogging } from '../../../components/TealiumLogging/Link'
import classnames from 'classnames'
import { hasCMSUserPermissions } from '@mc-review/helpers'
import { InfoTag } from '../../../components/InfoTag/InfoTag'

export type RateDetailsSummarySectionProps = {
contract: Contract | UnlockedContract
Expand Down Expand Up @@ -69,7 +70,7 @@ type PackageNamesLookupType = {
export function renderDownloadButton(
zippedFilesURL: string | undefined | Error
) {
if (zippedFilesURL instanceof Error) {
if (zippedFilesURL instanceof Error || !zippedFilesURL) {
return (
<InlineDocumentWarning message="Rate document download is unavailable" />
)
Expand Down Expand Up @@ -107,6 +108,15 @@ export const RateDetailsSummarySection = ({
? rateRevisions
: getVisibleLatestRateRevisions(contract, isEditing)

const withdrawnRateRevisions: RateRevision[] =
contract.withdrawnRates?.reduce((acc, rate) => {
const latestRevision = rate.packageSubmissions?.[0].rateRevision
if (rate.consolidatedStatus === 'WITHDRAWN' && latestRevision) {
acc.push(latestRevision)
}
return acc
}, [] as RateRevision[]) ?? []

// Calculate last submitted data for document upload tables
const lastSubmittedIndex = getIndexFromRevisionVersion(
contract,
Expand Down Expand Up @@ -227,8 +237,10 @@ export const RateDetailsSummarySection = ({
// get all the keys for the documents we want to zip
async function fetchZipUrl() {
const submittedRates =
getLastContractSubmission(contract)?.rateRevisions
if (submittedRates !== undefined) {
getLastContractSubmission(contract)?.rateRevisions ?? []

// skip if no rates
if (submittedRates.length > 0) {
const keysFromDocs = submittedRates
.flatMap((rateInfo) =>
rateInfo.formData.rateDocuments.concat(
Expand Down Expand Up @@ -279,6 +291,12 @@ export const RateDetailsSummarySection = ({
isAdminUser && !isLinkedRate && !isPreviousSubmission,
})

const showDownloadAllButton =
isSubmittedOrCMSUser &&
!isPreviousSubmission &&
rateRevs &&
rateRevs.length > 0

const noRatesMessage = () => {
if (isStateUser) {
return isSubmitted
Expand All @@ -299,9 +317,7 @@ export const RateDetailsSummarySection = ({
header="Rate details"
editNavigateTo={editNavigateTo}
>
{isSubmittedOrCMSUser &&
!isPreviousSubmission &&
renderDownloadButton(zippedFilesURL)}
{showDownloadAllButton && renderDownloadButton(zippedFilesURL)}
</SectionHeader>
{rateRevs && rateRevs.length > 0
? rateRevs.map((rateRev) => {
Expand Down Expand Up @@ -575,6 +591,21 @@ export const RateDetailsSummarySection = ({
: (isSubmitted || isStateUser) && (
<DataDetailMissingField requiredText={noRatesMessage()} />
)}
{withdrawnRateRevisions.length > 0 &&
withdrawnRateRevisions.map((rateRev) => (
<SectionCard
id={`withdrawn-rate-${rateRev.id}`}
key={rateRev.id}
>
<h3
aria-label={`Rate ID: ${rateRev.formData.rateCertificationName}`}
className={styles.rateName}
>
<InfoTag color="gray-medium">WITHDRAWN</InfoTag>{' '}
{rateRev.formData.rateCertificationName}
</h3>
</SectionCard>
))}
</SectionCard>
)
}

0 comments on commit f4c62c0

Please sign in to comment.