-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove incomplete warnings on submission summary page #2387
Remove incomplete warnings on submission summary page #2387
Conversation
…e-review into mcr-4072-incomplete-warnings-on-submission-summary-page
👋 Could we please handle this I'm seeing my recent work brought in Can you pick one approach and extend to both summary pages - there's not any divergence? I don't want us to have different implementations of feeding logic to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to allow merge -- but left a comment about something I would like to see adjusted at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes make sense to me, I agree with Hana about trying to make these checks consistent
I had to add tests for SHARED tag because the refactored fix to I intentionally chose to move toward a domain agnostic prop My reasoning -- Part of what I think caused regressions here is confusion about the intent of something like a Seems like ultimately what we needed a prop for is "do we conditionally show user feedback about validations and allow edit buttons, thus treating these documents as dynamic content that could be soon changed ... OR do we display this as read only historic data that is fine with its imperfections". |
…linked rates flag on
Summary
Related issues
https://jiraent.cms.gov/browse/MCR-4072
MCR-4069
https://jiraent.cms.gov/browse/MCR-4071
Test cases covered
QA Guidance