Fix form errors and styling on rate details page #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonLin0991
requested review from
haworku,
macrael,
ruizajtruss and
pearl-truss
and removed request for
haworku and
macrael
macrael
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed form errors not showing up and some styling.
Form Errors
Slack about form errors
under actuarial firm if I select "other" the validation error "you must enter a description" appears right away. It should only appear after I hit continue
If I am missing a form field in the additional actuaries and try to continue, I get only line item errors. I am NOT seeing the error appear within the error summary banner at the top like I would expect.
I also find "remove" to be vague given all the competing links. I would suggest "remove certifying actuary" or something like that. (there are a lot of links, something for Kelsey to noodle on I think, but not a blocker)
UI styling
Remove certifying actuarybuttonRelated issues
Screenshots
Test cases covered
QA guidance