Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCR-4873: update the contract actions section on rate summary page #3069

Merged
merged 3 commits into from
Jan 14, 2025
Merged

MCR-4873: update the contract actions section on rate summary page #3069

merged 3 commits into from
Jan 14, 2025

Conversation

JasonLin0991
Copy link
Contributor

@JasonLin0991 JasonLin0991 commented Jan 10, 2025 •
edited
Loading

Summary

MCR-4873

  • After a rate is withdrawn the contract actions it was associated with should still appear in the contract actions section.

Related issues

Screenshots

Test cases covered

SingleRateSummarySection.test.tsx

  • 'renders contract actions correctly after rate withdraw'

QA guidance

@JasonLin0991 JasonLin0991 added the AI Assist Github Copilot test for DSG label Jan 10, 2025
@JasonLin0991 JasonLin0991 marked this pull request as ready for review January 13, 2025 14:57
@JasonLin0991 JasonLin0991 changed the title Jl mcr 4873 update the contract actions section on rate summary page MCR-4873: update the contract actions section on rate summary page Jan 13, 2025
pearl-truss
pearl-truss approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@pearl-truss pearl-truss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasonLin0991 JasonLin0991 merged commit cc0ecdb into main Jan 14, 2025
28 checks passed
@JasonLin0991 JasonLin0991 deleted the jl-mcr-4873_update_the_contract_actions_section_on_rate_summary_page branch January 14, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearl-truss pearl-truss pearl-truss approved these changes

@haworku haworku Awaiting requested review from haworku

Assignees
No one assigned
Labels
AI Assist Github Copilot test for DSG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonLin0991 @pearl-truss