Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCR-4653: CMS does not see withdrawn rate reviews on dashboard by default #3083

Merged
merged 2 commits into from
Jan 16, 2025
Merged

MCR-4653: CMS does not see withdrawn rate reviews on dashboard by default #3083

merged 2 commits into from
Jan 16, 2025

Conversation

JasonLin0991
Copy link
Contributor

@JasonLin0991 JasonLin0991 commented Jan 15, 2025 •
edited
Loading

Summary

MCR-4653

AC:

  • If I hit my rate dashboard, withdrawn rates are filtered out by default

Other work:

  • Simplify loading filters from URL when the URL had filters
    • The original implementation was for some UI flickering. Seems like it's no longer an issue without it.

Related issues

Screenshots

Test cases covered

RatesReviewTable.tsx

  • 'renders rates table correctly'
    • Updated to assert withdrawn rate was not visible.

QA guidance

@JasonLin0991 JasonLin0991 added the AI Assist Github Copilot test for DSG label Jan 15, 2025
@JasonLin0991 JasonLin0991 marked this pull request as ready for review January 16, 2025 00:03
pearl-truss
pearl-truss approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@pearl-truss pearl-truss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement getting rid of the flickering

@JasonLin0991 JasonLin0991 merged commit 50536aa into main Jan 16, 2025
28 checks passed
@JasonLin0991 JasonLin0991 deleted the jl-MCR-4653-withdrawn-rates-filtered-out-by-default branch January 16, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearl-truss pearl-truss pearl-truss approved these changes

@haworku haworku Awaiting requested review from haworku

Assignees
No one assigned
Labels
AI Assist Github Copilot test for DSG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonLin0991 @pearl-truss