Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCR-4826: add round number to Question object #3092

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

pearl-truss
Copy link
Contributor

@pearl-truss pearl-truss commented Jan 21, 2025

Summary

This PR adds a round field to the API response for ContractQuestions. Can be seen when fetchContract is called

Related issues

https://jiraent.cms.gov/browse/MCR-4826

Screenshots

Screenshot 2025-01-22 at 11 24 12 AM

Test cases covered

  • QuestionResolver.test -> round number is populated

@pearl-truss pearl-truss changed the title [DRAFT] MCR-4826: add round number to Question and Response objects [DRAFT] MCR-4826: add round number to Question object Jan 22, 2025
@pearl-truss pearl-truss marked this pull request as ready for review January 22, 2025 16:31
@pearl-truss pearl-truss changed the title [DRAFT] MCR-4826: add round number to Question object MCR-4826: add round number to Question object Jan 22, 2025
Copy link
Contributor

@JasonLin0991 JasonLin0991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pearl-truss pearl-truss merged commit 7d265a2 into main Jan 23, 2025
28 checks passed
@pearl-truss pearl-truss deleted the pr-mcr-4826-add-round-number-to-fetchContract branch January 23, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants