-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCR-4893: Adjust Apollo handler to use feature flag #3099
MCR-4893: Adjust Apollo handler to use feature flag #3099
Conversation
…, and update LD service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's something going on. As a state user I was able to submit but didn't see any emails. One weird thing was going through the state submission form the Supporting Docs page was present but in LD the 'hide-supporting-docs' flag is turned on for dev
Also, as a CMS user I wasn't able to add a contract or rate question. I got the attached error regarding unable to send emails
Yea, looks like the way had the default emails in the Prisma schema caused email issues. The display name of the email is formatted incorrectly for AWS SES. We can use escape characters to make the default emails display name work, but it might cause issues with the escape characters. Instead I removed the email display name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to see some changes to the LDservice - I think rather than making up our own pattern we could use the anonymous user functionality of LD. I'm going to look into briefly see if its quick fix
FYI @pearl-truss the reason you saw that page is we have targetting on for aang user in LD. I did look into that |
closing in favor of the new #3116 |
Summary
MCR-4893
AC:
Additional work:
ldService
so that we can use it in before initialization and getting the user data. Before we passed ourContext
intoldService
methods and it would extract out the user's email for LaunchDarkly targeting. Now we have to explicitly give akey
to the method, which would be the email or any identifiable string.ldService
methods by giving it a default keyemail-configuration
. This flag is temporary so I think this should be ok. If we had some kind of permanent flag that is read from the handler, we should either figure out a way to get the user email or we define a newkind
in LaunchDarkly to label it correctly. Something likehandler
so that we know flag was read by the handler.cms.hhs.gov
email and only use ourtruss email.
EmailSettings
(values from the database) andEmailConfiguration
(values for the emailer).cmsReviewHelpEmailAddress
,cmsRateHelpEmailAddress
, andhelpDeskEmail
differ in types (string
andstring[]
). If we make the types the same we will have to update all the emailer functions, tests, mocks, and helpers. This seemed way out of scope for this ticket so I opted to just have theconfigureEmailerFromDatabase
function to handle the type difference for now and will spin up a new ticket for that work.EmailSettings
(values from the database) andEmailConfiguration
(values for the emailer)Related issues
Screenshots
Test cases covered
submitContract.test.ts
'uses email settings from database with remove-parameter-store flag on'
fetchMcReviewSettings.test.ts
'uses email settings from database with remove-parameter-store flag on'
QA guidance
dev
we wont see any changes on the settings page. Just test that emails still send.