Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor README.md for PGXN #262

Closed
wants to merge 10 commits into from
Closed

Refactor README.md for PGXN #262

wants to merge 10 commits into from

Conversation

mkgrgis
Copy link

@mkgrgis mkgrgis commented Jan 20, 2023

For unifying with https://github.com/pgspider FDW documentation template and by https://github.com/ibarwick/firebird_fdw/blob/master/README.md example of advanced FDW documentation.

@mkgrgis
Refactor README.md
b2b3f5b 
For unifying with https://github.com/pgspider FDW documentation template and by https://github.com/ibarwick/firebird_fdw/blob/master/README.md example of advanced FDW documentation.
@mkgrgis mkgrgis mentioned this pull request Jan 20, 2023
Merged
@mkgrgis
Copy link
Author

mkgrgis commented Nov 30, 2023 •
edited
Loading

Ping, my_sql FDW team ? Is the project still active? Are maintainers interesting in unified README.md for PostgreSQL extension network (PGXN) ?

@surajkharage19
Copy link

Hi @mkgrgis,

Yes, this project is active. We will look into the README changes suggested by you.

Thanks.

@mkgrgis
Copy link
Author

mkgrgis commented Dec 4, 2023

Hello, @surajkharage19 ! I am ready for review. Also I have similar PR for mongo_fdw EnterpriseDB/mongo_fdw#168 , but this will also stopped without any comments.

@mkgrgis
Copy link
Author

mkgrgis commented Jan 17, 2024

Hello, @surajkharage19! My MongoDB README.md refactoring was completely accepted in EnterpriseDB/mongo_fdw@373ea03, let's continue our review?

@mkgrgis mkgrgis changed the title Refactor README.md Refactor README.md for PGXN Jan 17, 2024
@mkgrgis
Copy link
Author

mkgrgis commented Apr 24, 2024 •
edited
Loading

Ping, @surajkharage19 ! Most of other PostgreSQL FDWs yet use documentation structure from this PR: EnterpriseDB mongo_fdw, redis_cluster_fdw, sqlite_fdw, firebird_fdw, influxdb_fdw etc. Why this review was stopped? I think mysql_fdw is very popular and provided by PGDG repository. Have my PR any problems?

@mkgrgis
Copy link
Author

mkgrgis commented Jul 3, 2024 •
edited
Loading

Ping @jeevanchalke , @surajkharage19 , @ALL, is this project still active? Does here reviews PRs at all?

jeevanchalke added a commit that referenced this pull request Jul 4, 2024
@jeevanchalke
Refactor README.md file.
c4103a3 
The main changes include unifying it with FDW documentation template.

Reported on GitHub through issue ##262 by mkgrgis (Михаил).

Initial patch by mkgrgis, further revised and improved by
Suraj Kharage.
@surajkharage19
Copy link

Hi @mkgrgis,

Sorry for the delay in reply. Thanks for submitting the pull request. We have committed this by making a few changes.

@mkgrgis
Copy link
Author

mkgrgis commented Jul 4, 2024

Thanks, @surajkharage19. I'll made next PR about README some time later.

@mkgrgis mkgrgis closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkgrgis @surajkharage19