Add the i16 dtype #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @ro99! This looks great and I'm happy to merge. It looks like a few CI tasks are failing though (including some build and formatting errors), could you please check that?
No worries about the build errors, I don't have a Mac so Metal/Accelerate development is always hard!
|
@ro99 let me know if you need any help! |
|
I will close this one and open a new, sorry, I was not expecting that the changes on the yml files would be added here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to the
DType::I16.I am trying to add support to the EXL2 format for Mistral.rs. I believe we may need the i16 type to have an equivalent to PyTorch short(). I am using the Aphrodite implementation as reference. Please let me know if this makes sense.