Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Patch Thrift deprecation for Python >=3.12 #4448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[web] Patch Thrift deprecation for Python >=3.12 #4448

wants to merge 1 commit into from
+145 −1

Conversation

gamesh411
Copy link
Collaborator

All of the currently available versions of Thrift use Python code that is deprected and gives an error when run on Python >=3.12. This change manually fixes the installed Thrift package. NOTE: This is a HACK and should be removed as soon as Thrift creates an updated version and CodeChecker is ported to use that version.

@gamesh411 gamesh411 force-pushed the patch-thrift-ugly-hack branch 4 times, most recently from 250d43c to 0e30c33 Compare February 5, 2025 19:59
@gamesh411
[web] Patch Thrift deprecation for Python >=3.12
839287e 
All of the currently available versions of Thrift use Python code that
is deprected and gives an error when run on Python >=3.12.
This change manually fixes the installed Thrift package.
NOTE: This is a HACK and should be removed as soon as Thrift creates an
updated version and CodeChecker is ported to use that version.
@gamesh411 gamesh411 force-pushed the patch-thrift-ugly-hack branch from 0e30c33 to 839287e Compare February 5, 2025 20:03
@gamesh411
Copy link
Collaborator Author

gamesh411 commented Feb 5, 2025 •
edited
Loading

This patch aims to help the issue #4437 .
This only patches the virtual environment that CodeChecker runs in.
I think CodeChecker packages installed from pypi just presuppose Thrift being installed in the site-packages, so this workaround only works when CodeChecker is run from venv or venv_dev.
Another route would be forking thrift itself and providing alternaltive pypi packages.
None of the above is satisfactory or feasible to maintain in the long run, but this version could at least work as a workaround for locally packaged CodeChecker.

@gamesh411 gamesh411 marked this pull request as ready for review February 5, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruntib bruntib Awaiting requested review from bruntib bruntib is a code owner

@vodorok vodorok Awaiting requested review from vodorok vodorok is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gamesh411