Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global_records_identifier configuration #332

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marshluca
Copy link

@marshluca marshluca commented Jan 10, 2024

we have a model using global records feature in acts_as_tenant gem

class Member < ApplicationRecord
  acts_as_tenant(:organization, has_global_records: true)
end

With a given tenant scope 1, It generates SQL like below:

SELECT `members`.* FROM `members` WHERE (`members`.`organization_id` = 1 OR `members`.`organization_id` IS NULL)

as the data increased, it spent about 2s, but after we changed the global records identifier to a number 3, the query time decreased to 70ms.

SELECT `members`.* FROM `members` WHERE `members`.`organization_id` IN (1, 3)

It looks like MySQL doesn't perform well on NULLvalues index.
So I proposed this pull request to make the global records identifier configurable.

ActsAsTenant.configure do |config|
  config.global_records_identifier = 3
end
Development [1] demo(main)> ActsAsTenant.global_records_identifier
3
Development [2] demo(main)> Member.all.to_sql
"SELECT `members`.* FROM `members`"
Development [3] demo(main)> ActsAsTenant.with_tenant(Organization.first) { Member.all.to_sql }
"SELECT `members`.* FROM `members` WHERE `members`.`organization_id` IN (1, 3)"
Development [4] demo(main)> ActsAsTenant.with_tenant(Organization.last) { Member.all.to_sql }
"SELECT `members`.* FROM `members` WHERE `members`.`organization_id` IN (2, 3)"

It doesn't change the default behaviour, hope it is acceptable.
Any feedback is welcome.
Thanks.

@marshluca marshluca changed the title Support global_records_identifier configuration Add global_records_identifier configuration Jan 10, 2024
@excid3
Copy link
Collaborator

excid3 commented Jan 10, 2024

This seems reasonable to me. Should add some documentation for it though.

@marshluca
Copy link
Author

marshluca commented Jan 12, 2024

This seems reasonable to me. Should add some documentation for it though.

@excid3 Thanks for the response!
I've updated the documentation, please let me know if I missed anything.

@marshluca
Copy link
Author

@excid3 I have made some updates, any feedback is welcome :)

This seems reasonable to me. Should add some documentation for it though.

@marshluca
Copy link
Author

Any feedback on this PR? @excid3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants