Add global_records_identifier
configuration
#332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have a model using global records feature in
acts_as_tenant
gemWith a given tenant scope
1
, It generates SQL like below:as the data increased, it spent about 2s, but after we changed the global records identifier to a number
3
, the query time decreased to 70ms.It looks like MySQL doesn't perform well on
NULL
values index.So I proposed this pull request to make the global records identifier configurable.
It doesn't change the default behaviour, hope it is acceptable.
Any feedback is welcome.
Thanks.