readme: used to_prepare instead of to_complete for tenant reset on console reload #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt_tenant on console reload.
pragun16
force-pushed
the
update-qol-tip-config
branch
from
24a0667 to
3177d40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description:
The QoL tip in the configuration option specifies the use of
to_completereloader callback to setActsAsTenant.current_tenantwhich works fine during the console startup but does not reset the tenant on console reload.Also referenced in this issue.
Proposed fix:
to_completedoes not seem to work well in a console environment and thus, replacing it withto_prepareresets the tenant correctly, although the callback runs twice on console reload!