Undo rust pinning: rust 1.83 -> 1.84.1 #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regression that caused increased compile times for jf-pcs has been fixed in rust 1.84.1 See rust-lang/rust#135457 We originally pinned rust to 1.83 in 220df37 to work around this regression.
sveitser
requested review from
philippecamacho,
ImJeremyHe,
jbearer,
tbro and
imabdulbasit
as code owners
imabdulbasit
approved these changes
Feb 3, 2025
rob-maron
pushed a commit
that referenced
this pull request
Feb 7, 2025
refactor: remove duplicate const `NUM_REPLICATED_TO_TRUST`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression that caused increased compile times for jf-pcs has been fixed in rust 1.84.1
See rust-lang/rust#135457
We originally pinned rust to 1.83 in
220df37 to work around this regression.
Updates the rust-overlay to include rust 1.84.1.