Remove onSizeChange in favor of new native APIs
#989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfeinzimer
changed the title
onSizeChange in favor of View.onSizeChange(perform:)onSizeChange in favor of onGeometryChange(for:of:action:)
philium
reviewed
Jan 8, 2025
Sources/ArcGISToolkit/Components/FloorFilter/LevelSelector.swift
Outdated
Show resolved
Hide resolved
Sources/ArcGISToolkit/Components/Popups/MediaPopupElementView.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Philip Ridgeway <[email protected]>
Co-Authored-By: Philip Ridgeway <[email protected]>
Co-authored-by: Philip Ridgeway <[email protected]>
dfeinzimer
changed the title
onSizeChange in favor of onGeometryChange(for:of:action:)onSizeChange in favor of new native APIs
Co-Authored-By: Philip Ridgeway <[email protected]>
This reverts commit 6995bf9.
Co-Authored-By: Philip Ridgeway <[email protected]>
philium
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
View.onSizeChange(perform:)which is emitting a Sendable warning in favor ofonScrollGeometryChange(for:of:action:)andonGeometryChange<T>(for:of:action:)which was added as of iOS 18 but is made available back to iOS 16.