chore(actions): add icon leads notification for calcite-ui-icons requests #11263
+42
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geospatialem
added
the
skip visual snapshots
github-actions
bot
added
the
chore
jcfranco
requested changes
Jan 11, 2025
| issue: { number }, | ||
| } = payload; | ||
|
|
||
| const { ICONLEADS } = process.env; |
There was a problem hiding this comment.
This should be renamed to match the env variable name defined here.
benelan
reviewed
Jan 11, 2025
There was a problem hiding this comment.
Why are tagging icon designers in a comment instead of assigning them (or the @Esri/calcite-icon-designers team) to the issue? I think designers would be notified either way, but it assigning would reduce noise for the issue author.
Edit: Actually you can't assign a team to an issue. But assigning the individual designer(s) is still an option.
| with: | ||
| script: | | ||
| const action = require('${{ github.workspace }}/.github/scripts/notifyAboutIconRequest.js') | ||
| await action({github, context, core}) |
There was a problem hiding this comment.
can you use the yml extension instead of yaml to align with the rest of the workflows?
| @@ -0,0 +1,32 @@ | |||
| // @ts-nocheck | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9922
Summary
Add automation to issues when the
calcite-ui-iconslabel is added, where Icon team leads will receive an@notification via a comment, similar to the new component label automation from the notifyAboutNewComponent script.cc @allieorth, @arowles