Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(color-picker): fix error caused by initial value with a different format #11351

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 21, 2025

Related Issue: #10731

Summary

Adds missing check to skip internal, equal values after transitioning to getters/setters in #10310.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 21, 2025
@jcfranco jcfranco added no changelog entry Use the commit override to avoid a changelog entry pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 21, 2025
@jcfranco jcfranco requested a review from driskull January 21, 2025 23:23
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jcfranco jcfranco merged commit 1d187da into dev Jan 22, 2025
21 checks passed
@jcfranco jcfranco deleted the jcfranco/10731-fix-color-picker-initial-value-error branch January 22, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. no changelog entry Use the commit override to avoid a changelog entry pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants