chore(icon): improve icon load error message #11367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
jcfranco
added
the
skip visual snapshots
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
benelan
added a commit
that referenced
this pull request
Jan 24, 2025
* origin/dev: (34 commits) build: update browserslist db (#11339) build(deps): update dependency lint-staged to v15.4.1 (#11343) chore: release next feat(graph): add component tokens (#11355) chore: release next fix(popover, tooltip): drop relative-positioning to reduce risk of clipping (#11373) chore: release next fix(date-picker): no longer disable min/max value month in select menu (#11350) chore(icon): improve icon load error message (#11367) fix(date-picker): remove outline for header actions (#11369) chore: release next fix(carousel): Ensure correct `autoplay` display and animation (#11338) chore: release next fix(flow): process items on loaded (#11364) chore: release next fix(combobox, stepper, table): respect user hidden attribute (#10983) refactor(action-pad): restore rounded styling (#11358) test(combobox): avoid emitting change event for value property update (#11281) chore: release next refactor(action-pad): remove unnecessary overflow css styling. (#11349) ...
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
**Related Issue:** N/A ## Summary This improves clarity by displaying the icon name and scale separately in the error message instead of an internal key used by icon utils: ```sh "measure16" is not a valid calcite-ui-icon name ``` ⬇️ ```sh measure (s) icon failed to load. ``` Also, this now uses the logger to display the `calcite` badge for additional context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: N/A
Summary
This improves clarity by displaying the icon name and scale separately in the error message instead of an internal key used by icon utils:
"measure16" is not a valid calcite-ui-icon name⬇️
Also, this now uses the logger to display the
calcitebadge for additional context.