fix(combobox): improve prop update times #11383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
added
the
pr ready for visual snapshots
driskull
approved these changes
Jan 25, 2025
| @@ -741,8 +749,8 @@ export class Combobox | |||
| } | |||
|
|
|||
| private getValue(): string | string[] { | |||
| const items = this.selectedItems.map((item) => item?.value?.toString()); | |||
| return items?.length ? (items.length > 1 ? items : items[0]) : ""; | |||
| const items = this.selectedItems.map((item) => item.value?.toString()); | |||
There was a problem hiding this comment.
This .toString() reminds me of #11370 where we may want to consider changing value from any to string.
jcfranco
added
the
no changelog entry
github-actions
bot
added this to the 2025-02-06 - 3.0.0 Feb Breaking Change Release milestone
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10731
Summary
Fixes prop update delays introduced in #10310 by moving event emitting to Lit's pre-update phase.
BEGIN_COMMIT_OVERRIDE
omitted from changelog
END_COMMIT_OVERRIDE