Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): update internal state after custom value is added #11405

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 29, 2025

Related Issue: #10731, #11382

Summary

This updates the combobox internal state after an custom item is added.

Note: this also adds createEventTimePropValuesAsserter to help assert on event-emit time component state.

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 29, 2025
@jcfranco jcfranco added ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing. and removed ArcGIS Knowledge Issues logged by ArcGIS Knowledge team members. labels Jan 29, 2025
@jcfranco jcfranco marked this pull request as ready for review January 29, 2025 19:08
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! updateItems being called on adding chip should be fine since it doesn't occur often.

@jcfranco
Copy link
Member Author

@driskull Agreed. We might need to refactor combobox to update state in a more granular fashion. E.g., adding a custom item should update internal items and its filtering data, but probably doesn't need to filter at that time.

@jcfranco jcfranco merged commit b6b6525 into dev Jan 29, 2025
11 checks passed
@jcfranco jcfranco deleted the jcfranco/10731-fix-incorrect-state-updates-with-allow-custom-values branch January 29, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. no changelog entry Use the commit override to avoid a changelog entry skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants