feat(panel): add content-bottom slot #9311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
Elijbet
added
the
pr ready for visual snapshots
jcfranco
approved these changes
May 10, 2024
| @@ -328,6 +331,10 @@ export class Panel | |||
| this.hasFab = slotChangeHasAssignedElement(event); | |||
| }; | |||
|
|
|||
| private contentBottomSlotChangeHandler = (event: Event): void => { | |||
| this.hasContentBottom = slotChangeHasAssignedElement(event); | |||
There was a problem hiding this comment.
I may have missed this in the content-top slot PR, but should this use slotChangeHasContent to consider both text and elements?
There was a problem hiding this comment.
Everywhere I look we use slotChangeHasAssignedElement, and slotChangeHasContent is only used once, in
scrim. Do we want to handle both (elements and text) in all cases, or is checking for text not needed everywhere?
There was a problem hiding this comment.
@Elijbet we only need to consider slotChangeHasContent for unnamed default slots. Otherwise, an element is used with a slot="x".
packages/calcite-components/src/components/panel/panel.stories.ts
Outdated
Show resolved
Hide resolved
macandcheese
approved these changes
May 10, 2024
Elijbet
added
skip visual snapshots
Elijbet
added
pr ready for visual snapshots
Merged
geospatialem
modified the milestones:
2024-05-14 - May maintenance release,
2024-05-28 - May Main Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8979
Summary
Add a new
content-bottomslot to thepanelcomponent.