Endpoint change #51
Closed
Endpoint change #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed from the new /SearchSeriesResults endpoint
Add flake8 linting task
Fix code formatting in setup.py
custid to cust_id lowername to name_lower shortname to name_short
SubSessionData.league_id SubSessionData.league_season_id SubSessionData.points_type SubSessionData.reserve_status SubSessionData.season_name SubSessionData.season_name_short SubSessionData.series_name SubSessionData.series_name_short SubSessionData.session_name SubSessionData.special_event_type_text SubSessionData.time_start SubSessionData.time_start_sim SubSessionData.track SubSessionData.track_config
…ed it. Added parse_encode to objects with newly completed documentation to see the data
We previously had the help message inside the error we are raising, but we really want to be logging that as that is where users will be looking for help. Inside the error we can just dump the entire response. This might be absurd and too much content, but it at least allows them to make decisions based on this if they want.
We currently raise a `UserWarning` when we fail auth which isn't very descriptive and doesn't tell us what actually failed.
This is a more accurate error for what is actually happening and lets us save the actual response in case the user wants to do something with it.
Add a check for empty event results
Bump version to 0.1.1 for a release
Improve Login Flow
Fixed issue #74 (string replace is no longer required)
This is how we will model the data we get back from the league standings endpoint.
This allows us to get the standings for a leage given the league ID and league season ID. This can take in more parameters, but those are documented on the URL, and I don't really see the use, so they can be added later.
This does not include previous and next race, because I think those might require some more thought, but this does give us the basics for gettings the seasons for a league.
This lets us get the seasons for a given league so we can use them to query leaderboard.
Add League Standings Endpoint
Add League Seasons
This will have `+` in all the spaces, as well as other weird encoding things that iRacing uses, so we want them removed.
This is how we can get some specific data about a league by ID.
We want to represent all the data we can get from iRacing about leagues. This only omits the data about images, since we don't have access to the actual image anyways.
This is how we can get some basic data about a league from an ID.
This was just a typo, looks like a bad copy/paste. `pos` is the field that represents position.
Fix position
…into endpoint-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #50 by making changes to the constants.py URL, the EventResult response object, and the event_results parameters.