Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a figure size to Scan.plot() #262

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

JamesWrigley
Copy link
Member

No description provided.

@JamesWrigley JamesWrigley added the enhancement New feature or request label Nov 23, 2024
@JamesWrigley JamesWrigley self-assigned this Nov 23, 2024
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.93%. Comparing base (3d35442) to head (535fcd9).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   73.93%   73.93%           
=======================================
  Files          23       23           
  Lines        2996     2996           
=======================================
  Hits         2215     2215           
  Misses        781      781           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philsmt
Copy link
Collaborator

philsmt commented Nov 25, 2024

Why single out figsize and not use the already existing mechanism to pass an Axes object?

@JamesWrigley
Copy link
Member Author

It's annoying to create a figure manually when all you want to do is change the size, which I think is by far the most common figure-level setting you'd want to change.

@JamesWrigley
Copy link
Member Author

(if there's no objections I'll merge this at the end of the week)

@takluyver
Copy link
Member

Fine by me 👍

@JamesWrigley JamesWrigley merged commit 9544407 into master Nov 27, 2024
12 checks passed
@JamesWrigley JamesWrigley deleted the scan-plot branch November 27, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants