Test workflow

EventStore · Jan 7, 2025 · 46ade80 · 46ade80
1 parent a0dd296
commit 46ade80
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/.github/workflows/base.yml b/.github/workflows/base.yml
@@ -25,7 +25,7 @@ jobs:
     strategy:      
       fail-fast: false
       matrix:
-        framework: [ net9.0 ]
+        framework: [ net8.0 ]
         os: [ ubuntu-latest ]
         configuration: [ release ]
     runs-on: ${{ matrix.os }}
@@ -53,6 +53,7 @@ jobs:
       uses: actions/setup-dotnet@v3
       with:
         dotnet-version: |
+          8.0.x
           9.0.x
     - name: Run Tests
       shell: bash

diff --git a/test/Kurrent.Client.Tests.Common/Fixtures/KurrentPermanentFixture.cs b/test/Kurrent.Client.Tests.Common/Fixtures/KurrentPermanentFixture.cs
@@ -37,9 +37,9 @@ protected KurrentPermanentFixture(ConfigureFixture configure) {
 
 	public ILogger Log => Logger;
 
-	public ITestService             Service { get; }
+	public ITestService          Service { get; }
 	public KurrentFixtureOptions Options { get; }
-	public Faker                    Faker   { get; } = new Faker();
+	public Faker                 Faker   { get; } = new Faker();
 
 	public Version EventStoreVersion               { get; private set; } = null!;
 	public bool    EventStoreHasLastStreamPosition { get; private set; }
@@ -87,13 +87,12 @@ public async Task InitializeAsync() {
 		await ContainerSemaphore.WaitAsync();
 		try {
 			await Service.Start();
+			EventStoreVersion               = GetEventStoreVersion();
+			EventStoreHasLastStreamPosition = (EventStoreVersion?.Major ?? int.MaxValue) >= 21;
 		} finally {
 			ContainerSemaphore.Release();
 		}
 
-		EventStoreVersion               = GetEventStoreVersion();
-		EventStoreHasLastStreamPosition = (EventStoreVersion?.Major ?? int.MaxValue) >= 21;
-
 		await WarmUpGatekeeper.WaitAsync();
 
 		try {

diff --git a/test/Kurrent.Client.Tests.Common/Fixtures/KurrentTemporaryFixture.cs b/test/Kurrent.Client.Tests.Common/Fixtures/KurrentTemporaryFixture.cs
@@ -40,9 +40,9 @@ protected KurrentTemporaryFixture(ConfigureFixture configure) {
 
 	public ILogger Log => Logger;
 
-	public ITestService             Service { get; }
+	public ITestService          Service { get; }
 	public KurrentFixtureOptions Options { get; }
-	public Faker                    Faker   { get; } = new Faker();
+	public Faker                 Faker   { get; } = new Faker();
 
 	public Version EventStoreVersion               { get; private set; } = null!;
 	public bool    EventStoreHasLastStreamPosition { get; private set; }
@@ -89,13 +89,12 @@ public async Task InitializeAsync() {
 		await ContainerSemaphore.WaitAsync();
 		try {
 			await Service.Start();
+			EventStoreVersion               = GetEventStoreVersion();
+			EventStoreHasLastStreamPosition = (EventStoreVersion?.Major ?? int.MaxValue) >= 21;
 		} finally {
 			ContainerSemaphore.Release();
 		}
 
-		EventStoreVersion               = GetEventStoreVersion();
-		EventStoreHasLastStreamPosition = (EventStoreVersion?.Major ?? int.MaxValue) >= 21;
-
 		await WarmUpGatekeeper.WaitAsync();
 
 		try {