.NET 4.8 Framework support #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-70 .NET Framework support
We need to take into account users who are on .NET Framework, TCP client & V5 moving to later DB versions but not to .NET Core or .NET 6+ yet. |
|
I did some initial work to add .NET Framework 4.8 (can be lowered to 4.7.1) support back to the new client. The main issue that remains is lack of |
|
Not sure how to add tests there as it builds on Ubuntu. Need to remove net5.0 from the matrix. Maybe add a separate job for 4.8, running on Windows? |
added specific test step for windows net48
fixed gencert (on macos at least)
thefringeninja
force-pushed
the
dev-70-net-framework-support
branch
from
c0051ac to
1ffb490
Compare
thefringeninja
force-pushed
the
dev-70-net-framework-support
branch
from
1ffb490 to
26869d9
Compare
RagingKore
changed the title
RagingKore
reviewed
Jan 19, 2024
test/EventStore.Client.Streams.Tests/EventStore.Client.Streams.Tests.csproj
Outdated
Show resolved
Hide resolved
test/EventStore.Client.Tests.Common/EventStore.Client.Tests.Common.csproj
Outdated
Show resolved
Hide resolved
test/EventStore.Client.Tests.Common/Fixtures/EventStoreTestCluster.cs
Outdated
Show resolved
Hide resolved
test/EventStore.Client.Tests.Common/FluentDocker/FluentDockerServiceExtensions.cs
Outdated
Show resolved
Hide resolved
src/EventStore.Client/Interceptors/TypedExceptionInterceptor.cs
Outdated
Show resolved
Hide resolved
RagingKore
reviewed
Jan 19, 2024
test/EventStore.Client.Tests.Common/FluentDocker/TestService.cs
Outdated
Show resolved
Hide resolved
RagingKore
reviewed
Jan 19, 2024
RagingKore
changed the title
josephcummings
approved these changes
Jan 29, 2024
w1am
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.