DEV-125 - Fix partial append on error append to stream #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1am
force-pushed
the
w1am/dev-125-appendtostream-can-write-a-subset-of-events-when-errors
branch
2 times, most recently
from
0fe8ffa to
1159799
Compare
w1am
force-pushed
the
w1am/dev-125-appendtostream-can-write-a-subset-of-events-when-errors
branch
12 times, most recently
from
ec749e7 to
e2e1947
Compare
w1am
force-pushed
the
w1am/dev-125-appendtostream-can-write-a-subset-of-events-when-errors
branch
from
e2e1947 to
9be6e8a
Compare
josephcummings
suggested changes
Feb 13, 2024
RagingKore
requested changes
Feb 13, 2024
test/EventStore.Client.Streams.Tests/Append/append_to_stream.cs
Outdated
Show resolved
Hide resolved
w1am
force-pushed
the
w1am/dev-125-appendtostream-can-write-a-subset-of-events-when-errors
branch
from
e4c580d to
5b02572
Compare
w1am
force-pushed
the
w1am/dev-125-appendtostream-can-write-a-subset-of-events-when-errors
branch
from
160e980 to
f28f2c3
Compare
RagingKore
approved these changes
Feb 26, 2024
josephcummings
changed the title
josephcummings
deleted the
w1am/dev-125-appendtostream-can-write-a-subset-of-events-when-errors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: Issue #250
This PR addresses 2 issues:
It ensures that exceptions especially those arising from broken enumerables and gRPC operations are efficiently propagated back to the caller.
Following from the first point, calls to RequestStream.WriteAsync could throw an RpcException in scenarios where wrong credentials were provided. This occurs before RequestStream.CompleteAsync calls were made to append events, leading to unhandled exceptions. Therefore, the response.RequestStream in the TypedExceptionInterceptor was enhanced to address the race condition issue by ensuring exceptions are properly caught and translated. Credit goes to @josephcummings!