fixed visibility of some methods on the plugin class

EventStore · May 15, 2024 · 399b7fc · 399b7fc
1 parent 595d85a
commit 399b7fc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/EventStore.Plugins/Plugin.cs b/src/EventStore.Plugins/Plugin.cs
@@ -78,11 +78,11 @@ protected Plugin(PluginOptions options) : this(
     /// <inheritdoc />
     public bool Enabled => IsEnabledResult.Enabled;
 
-    public virtual void ConfigureServices(IServiceCollection services, IConfiguration configuration) { }
+    protected virtual void ConfigureServices(IServiceCollection services, IConfiguration configuration) { }
 
-    public virtual void ConfigureApplication(IApplicationBuilder app, IConfiguration configuration) { }
+    protected virtual void ConfigureApplication(IApplicationBuilder app, IConfiguration configuration) { }
 
-    public virtual (bool Enabled, string EnableInstructions) IsEnabled(IConfiguration configuration) => (true, "");
+    protected virtual (bool Enabled, string EnableInstructions) IsEnabled(IConfiguration configuration) => (true, "");
 
     IServiceCollection IPlugableComponent.ConfigureServices(IServiceCollection services, IConfiguration configuration) {
         Configuration   = configuration;

diff --git a/test/EventStore.Plugins.Tests/Diagnostics/PluginMetricsTests.cs b/test/EventStore.Plugins.Tests/Diagnostics/PluginMetricsTests.cs
@@ -40,7 +40,7 @@ public void can_receive_metrics_from_plugin() {
     class AdamSmasherPlugin(params KeyValuePair<string, object?>[] diagnosticsTags) : Plugin(diagnosticsTags: diagnosticsTags) {
         public Counter<int> TestCounter { get; private set; } = null!;
 
-        public override void ConfigureApplication(IApplicationBuilder app, IConfiguration configuration) {
+        protected override void ConfigureApplication(IApplicationBuilder app, IConfiguration configuration) {
             var meterFactory = app.ApplicationServices.GetRequiredService<IMeterFactory>();
 
             var meter = meterFactory.Create(DiagnosticsName, Version, DiagnosticsTags);