-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV-52] Plugins reloaded: Metrics and Diagnostics support #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new subsystem plugin base class with default Meter removed serilog code cleanup
fixed some comments
better docs more tests modified sln moving tests into test folder and solution file and editorconfig to root.
back to the original Configure method on the IPlugableComponent added sync methods to the License automatic license check if public license key is present new plugin license exception for missing or invalid license moar tests
timothycoleman
approved these changes
May 16, 2024
YoEight
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: new Plugin base class for a simpler implementation with diagnostics and metrics support
Added: new SubsystemsPlugin base class for a simpler implementation with diagnostics and metrics support
Added: PluginDiagnosticsDataCollector to collect all data diags from the plugins
Added: automatic license checking if a licence public key is provided.
Fixed: Licence test
Changed: IPlugableComponent removing CollectTelemetry method and adding other properties like Name and Version
Removed: Serilog dependency
Background and Motivation
Creating plugins should be simpler, and support pushing metrics and diagnostics data to the host.
Connectors are a prime example of a plugin that requires all these capabilities on top of an improved dev ex.
Solution
Plugin
base class has the capability to publish diagnostics to the system viaDiagnosticsListener
.CollectTelemetry
operation.Plugin
,Component
andSubsystem
andSubsystems
PluginDiagnosticsDataCollector
component to be used in ESDB in order to replace theTelemetryService
logic.Bonus
Serilog
as we can simply use the systemILogger
if needed.