Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

26 global variables #39

Merged
merged 10 commits into from
Nov 16, 2023
Merged

26 global variables #39

merged 10 commits into from
Nov 16, 2023

Conversation

araszka
Copy link
Member

@araszka araszka commented Nov 11, 2023

No description provided.

@araszka araszka requested a review from snixtho November 11, 2023 14:27
@araszka araszka linked an issue Nov 11, 2023 that may be closed by this pull request
/// <summary>
/// Set a global variable that is passed to every component on render.
/// </summary>
public Task SetGlobalVariable(string key, object value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps its a better idea to use properties for these instead of methods? Seems unecessary.

@kdankert kdankert self-requested a review November 16, 2023 11:36
Copy link
Member

@kdankert kdankert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me. We should think about how to handle multiple registrations of the same global variable name though. A simple warning might be sufficient.

@araszka araszka merged commit cadb92d into master Nov 16, 2023
@araszka araszka deleted the 26_Global-Variables branch November 16, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global variables
3 participants