Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen the VOF unit test tolerance #1299

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Sep 23, 2024

On my laptop, this:

[+]  z3fyz4z  nalu-wind@master%[email protected] cxxflags=-D_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION ~asan~boost~catalyst~cdash_submit~cuda~fftw~fsi~gpu-aware-mpi+hypre~ipo~ninja~openfast+pic~rocm~shared~tests~tioga+trilinos-solvers~umpire+unit-tests~wind-utils abs_tol=1e-15 build_system=cmake build_type=Release ctest_args='-R unit' dev_path=/Users/mhenryde/exawind/exawind-manager/environments/nalu-wind-dev/nalu-wind generator=make reference_golds=default rel_tol=1e-12 arch=darwin-ventura-m1

leads to a unit test failure in VOFKernelHex8Mesh.NGP_adv_diff_edge_tpetra

  RUN      ] VOFKernelHex8Mesh.NGP_adv_diff_edge_tpetra
/Users/mhenryde/exawind/exawind-manager/environments/nalu-wind-dev/nalu-wind/unit_tests/UnitTestTpetraHelperObjects.h:130: Failure
The difference between vals[offset] and constRowView.value(j) is 1.4210854715202004e-14, which exceeds tol, where
vals[offset] evaluates to -83.128243716220496,
constRowView.value(j) evaluates to -83.12824371622051, and
tol evaluates to 1e-14.
i: 1, j: 2
/Users/mhenryde/exawind/exawind-manager/environments/nalu-wind-dev/nalu-wind/unit_tests/UnitTestTpetraHelperObjects.h:141: Failure
The difference between rhs[i] and localRhs(i, 0) is 2.8421709430404007e-14, which exceeds tol, where
rhs[i] evaluates to 166.25648743244099,
localRhs(i, 0) evaluates to 166.25648743244102, and
tol evaluates to 1e-14.
i: 1

I am attributing this to some compiler differences since the unit tests don't fail on ellis. I would still like them to pass on my machine so I am loosening the tolerance to 1e-13 for this test.

@jrood-nrel jrood-nrel enabled auto-merge (squash) September 23, 2024 16:36
@jrood-nrel jrood-nrel merged commit 6598e48 into Exawind:master Sep 23, 2024
3 checks passed
@marchdf marchdf deleted the vof-unit-tol branch September 25, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants