-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oscillating mesh motion #1329
Oscillating mesh motion #1329
Conversation
84c87cf
to
fbff59f
Compare
Looking good so far. I agree that it needs a regression test. How will the input work for this? I am not seeing links between it and our typical yaml input |
@wjhorne what kind of reg test would make sense? I am thinking it would be nalu-nalu overset, but is there a non-overset case that would make sense? |
I could be wrong, but I believe that there is not an option to do mesh motion via mesh distortion rather than overset unfortunately. This would mean we need an overset-overset case to get this through |
Sounds good. I'll try to set up a reg test today using the existing reg tests as templates. |
86649c4
to
bc0db33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go !
@mbkuhn Not sure why this isn't merging given you set it to auto and I approved it. Is it due to a necessary rebase of the branch? I think we are good to go for a merge |
No description provided.