Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oscillating mesh motion #1329

Merged
merged 7 commits into from
Dec 9, 2024
Merged

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Nov 25, 2024

No description provided.

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Nov 25, 2024

needs a reg test.

This should be useful for testing the overset solver, but more specifically, it's set up for the 2.5D OC7 cases. Pretty straightforward stuff. For thoroughness, here is what I am copying from (in the OC7 definition document).

image

@mbkuhn mbkuhn requested a review from wjhorne November 25, 2024 22:26
@mbkuhn mbkuhn force-pushed the oscillating_mesh_motion branch from 84c87cf to fbff59f Compare November 25, 2024 22:32
@wjhorne
Copy link
Contributor

wjhorne commented Nov 26, 2024

Looking good so far. I agree that it needs a regression test. How will the input work for this? I am not seeing links between it and our typical yaml input

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Dec 2, 2024

@wjhorne what kind of reg test would make sense? I am thinking it would be nalu-nalu overset, but is there a non-overset case that would make sense?

@wjhorne
Copy link
Contributor

wjhorne commented Dec 4, 2024

I could be wrong, but I believe that there is not an option to do mesh motion via mesh distortion rather than overset unfortunately. This would mean we need an overset-overset case to get this through

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Dec 4, 2024

Sounds good. I'll try to set up a reg test today using the existing reg tests as templates.

@mbkuhn mbkuhn force-pushed the oscillating_mesh_motion branch from 86649c4 to bc0db33 Compare December 5, 2024 22:30
@mbkuhn mbkuhn enabled auto-merge (squash) December 5, 2024 23:24
Copy link
Contributor

@wjhorne wjhorne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go !

@wjhorne
Copy link
Contributor

wjhorne commented Dec 9, 2024

@mbkuhn Not sure why this isn't merging given you set it to auto and I approved it. Is it due to a necessary rebase of the branch? I think we are good to go for a merge

@jrood-nrel jrood-nrel requested a review from wjhorne December 9, 2024 18:34
@mbkuhn mbkuhn disabled auto-merge December 9, 2024 20:30
@mbkuhn mbkuhn merged commit 138a324 into Exawind:master Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants