Refactor CI for Better Maintainability #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisal-bhuiyan
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
I think it was about automatically building/deploying documentation of some kind? It never actually did anything, as far as I can tell.
.github/workflows/correctness.yaml
Outdated
There was a problem hiding this comment.
Should we call this correctness-ubuntu.yaml and the other one correctness-macOS.yaml?
There was a problem hiding this comment.
Good idea. Will do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After several iterations of having to patch up CI, it was looking pretty messy. This clean-up simplifies our setup for each CI run (no longer depending on a github action for setting the compiler) and splits apart MacOS, Linux, ClangFormat, ClangTidy, and CppCheck into different files/jobs.
This is just #205 rebased on main.