Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readability-make-member-function-const #45

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Fix readability-make-member-function-const #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e585417
Fix readability-make-member-function-const.
jrood-nrel Jul 25, 2024
ce169f2
Suppress bugprone-easily-swappable-parameters.
jrood-nrel Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
Checks: 'bugprone-*,
-bugprone-exception-escape,
-bugprone-easily-swappable-parameters,
clang-diagnostic-*,
clang-analyzer-*,
corecppguidelines-*,
Expand Down
2 changes: 1 addition & 1 deletion src/MeshBlock.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1898,7 +1898,7 @@ void MeshBlock::getQueryPoints2(
TIOGA_FREE(inode);
}

void MeshBlock::writeOBB(int bid)
void MeshBlock::writeOBB(int bid) const
{
FILE* fp;
char intstring[12];
Expand Down
18 changes: 9 additions & 9 deletions src/MeshBlock.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,13 +311,13 @@ class MeshBlock

void search();
void search_uniform_hex();
void writeOBB(int bid);
void writeOBB(int bid) const;

void writeOBB2(OBB* obc, int bid);

void updateSolnData(int inode, double* qvar, double* q);
void updateSolnData(int inode, double* qvar, double* q) const;

int getNinterp() { return ninterp; };
int getNinterp() const { return ninterp; };

void getInterpolatedSolution(
int* nints,
Expand Down Expand Up @@ -384,7 +384,7 @@ class MeshBlock

/** routines that do book keeping */

void getDonorPacket(PACKET* sndPack, int nsend);
void getDonorPacket(PACKET* sndPack, int nsend) const;

void initializeDonorList();

Expand Down Expand Up @@ -426,9 +426,9 @@ class MeshBlock

void clearIblanks();

void getStats(int mstat[2]);
void getStats(int mstat[2]) const;

void setIblanks(int inode);
void setIblanks(int inode) const;

void getDonorCount(int* dcount, int* fcount);

Expand Down Expand Up @@ -490,7 +490,7 @@ class MeshBlock
double** realData,
double* q,
int nvar,
int interptype);
int interptype) const;
void updatePointData(double* q, double* qtmp, int nvar, int interptype);
void outputOrphan(FILE* fp, int i)
{
Expand Down Expand Up @@ -523,9 +523,9 @@ class MeshBlock
* Get donor packet for multi-block/partition setups
*
*/
void getMBDonorPktSizes(std::vector<int>&, std::vector<int>&);
void getMBDonorPktSizes(std::vector<int>&, std::vector<int>&) const;

void getMBDonorPackets(std::vector<int>&, std::vector<int>&, PACKET*);
void getMBDonorPackets(std::vector<int>&, std::vector<int>&, PACKET*) const;

/** Reset interpolation list data structure
*
Expand Down
12 changes: 7 additions & 5 deletions src/bookKeeping.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#include "tioga_math.h"
#include "tioga_utils.h"

void MeshBlock::getDonorPacket(PACKET* sndPack, int nsend)
void MeshBlock::getDonorPacket(PACKET* sndPack, int nsend) const
{
int i, k;
int* icount;
Expand Down Expand Up @@ -72,7 +72,7 @@
}

void MeshBlock::getMBDonorPktSizes(
std::vector<int>& nints, std::vector<int>& nreals)
std::vector<int>& nints, std::vector<int>& nreals) const
{
for (int i = 0; i < nsearch; i++) {
if (donorId[i] > -1) {
Expand All @@ -84,7 +84,9 @@
}

void MeshBlock::getMBDonorPackets(
std::vector<int>& ixOffset, std::vector<int>& rxOffset, PACKET* sndPack)
std::vector<int>& ixOffset,
std::vector<int>& rxOffset,
PACKET* sndPack) const
{
for (int i = 0; i < nsearch; i++) {
if (donorId[i] < 0) {
Expand Down Expand Up @@ -877,7 +879,7 @@
}
}

void MeshBlock::getStats(int mstats[2])
void MeshBlock::getStats(int mstats[2]) const

Check notice

Code scanning / CodeQL

No raw arrays in interfaces Note

Raw arrays should not be used in interfaces. A container class should be used instead.
{
int i;
mstats[0] = mstats[1] = 0;
Expand All @@ -891,7 +893,7 @@
}
}

void MeshBlock::setIblanks(int inode)
void MeshBlock::setIblanks(int inode) const
{
/* if (fabs(nodeRes[inode]-BIGVALUE) < TOL)
{
Expand Down
2 changes: 1 addition & 1 deletion src/dataUpdate.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ void MeshBlock::getInterpolatedSolution(
if (qq != nullptr) TIOGA_FREE(qq);
}

void MeshBlock::updateSolnData(int inode, double* qvar, double* q)
void MeshBlock::updateSolnData(int inode, double* qvar, double* q) const
{
int k;

Expand Down
2 changes: 1 addition & 1 deletion src/highOrder.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ void MeshBlock::getInterpolatedSolutionAtPoints(
double** realData,
double* q,
int nvar,
int interptype)
int interptype) const
{
int i;
int k, m, inode;
Expand Down
6 changes: 3 additions & 3 deletions src/parallelComm.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#include "parallelComm.h"
#define REAL double

void parallelComm::sendRecvPacketsAll(PACKET* sndPack, PACKET* rcvPack)
void parallelComm::sendRecvPacketsAll(PACKET* sndPack, PACKET* rcvPack) const
{
int i;
int *sint, *sreal, *rint, *rreal;
Expand Down Expand Up @@ -403,7 +403,7 @@ void parallelComm::getMap(int* ns, int* nr, int** snd, int** rcv)
return;
}

void parallelComm::clearPackets(PACKET* sndPack, PACKET* rcvPack)
void parallelComm::clearPackets(PACKET* sndPack, PACKET* rcvPack) const
{
int i;
//
Expand All @@ -422,7 +422,7 @@ void parallelComm::clearPackets(PACKET* sndPack, PACKET* rcvPack)
//
}

void parallelComm::initPackets(PACKET* sndPack, PACKET* rcvPack)
void parallelComm::initPackets(PACKET* sndPack, PACKET* rcvPack) const
{
int i;
//
Expand Down
6 changes: 3 additions & 3 deletions src/parallelComm.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class parallelComm
}
}

void sendRecvPacketsAll(PACKET* sndPack, PACKET* rcvPack);
void sendRecvPacketsAll(PACKET* sndPack, PACKET* rcvPack) const;

void sendRecvPackets(PACKET* sndPack, PACKET* rcvPack);

Expand All @@ -71,9 +71,9 @@ class parallelComm

void getMap(int* ns, int* nr, int** snd, int** rcv);

void initPackets(PACKET* sndPack, PACKET* rcvPack);
void initPackets(PACKET* sndPack, PACKET* rcvPack) const;

void clearPackets(PACKET* sndPack, PACKET* rcvPack);
void clearPackets(PACKET* sndPack, PACKET* rcvPack) const;
};

#endif /* PARALLELCOMM_H */
4 changes: 2 additions & 2 deletions src/tioga.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ class tioga
void assembleCompositeComms();
void assembleCompositeMap();

int getNumCompositeBodies() { return ncomposite; }
int getNumCompositeBodies() const { return ncomposite; }
void setNumCompositeBodies(int ncomposite);

void registerCompositeBody(
Expand Down Expand Up @@ -241,7 +241,7 @@ class tioga

/** set hole map algorithm: [0] original hole map, [1] adaptive hole map */
void setHoleMapAlgorithm(int alg) { USE_ADAPTIVE_HOLEMAP = alg; };
int getHoleMapAlgorithm() { return USE_ADAPTIVE_HOLEMAP; };
int getHoleMapAlgorithm() const { return USE_ADAPTIVE_HOLEMAP; };
/** set symmetry bc */
void setSymmetry(int syminput) { isym = syminput; };
/** set resolutions for nodes and cells */
Expand Down
Loading