Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SysId configuration, #408

Merged
merged 4 commits into from
Oct 26, 2024
Merged

Add SysId configuration, #408

merged 4 commits into from
Oct 26, 2024

Conversation

LupusTheCanine
Copy link
Contributor

Add SysId configuration, requires ExpressLRS/ExpressLRS#2891 (assumes live reconfiguration of sysID)

@wvarty
Copy link
Contributor

wvarty commented Sep 7, 2024

@LupusTheCanine this PR looks like it needs some words added to the .wordlist.txt file before it will pass the spellcheck job. Check the logs for details.

wvarty
wvarty previously requested changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@wvarty wvarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make spellcheck happy.

@wvarty wvarty mentioned this pull request Sep 10, 2024
Merged
@maybenikhil maybenikhil dismissed wvarty’s stale review October 24, 2024 07:08

wordlist updated. passing spellcheck

@maybenikhil maybenikhil added the wait-on-source PRs for new features waiting for their PRs to be merged/in a release. label Oct 24, 2024
@maybenikhil
Copy link
Member

waiting on ExpressLRS/ExpressLRS#2964 to be merged (assuming i'm not being braindead)

@LupusTheCanine
Copy link
Contributor Author

waiting on ExpressLRS/ExpressLRS#2964 to be merged (assuming i'm not being braindead)

Yes, unfortunately I didn't have much time to work on that, the only difference is that right now an RX serial reinitialization (reboot?) is required.

@maybenikhil
Copy link
Member

would it be accurate to then add another line saying to reboot the RX again?

@wvarty
Copy link
Contributor

wvarty commented Oct 26, 2024

waiting on ExpressLRS/ExpressLRS#2964 to be merged (assuming i'm not being braindead)

That PR is an additional enhancement on the functionality. This can and should be merged without waiting on that PR. The feature is already there is 3.5.0

@maybenikhil maybenikhil merged commit fe28658 into ExpressLRS:master Oct 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvarty wvarty wvarty approved these changes

Assignees
No one assigned
Labels
wait-on-source PRs for new features waiting for their PRs to be merged/in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LupusTheCanine @wvarty @maybenikhil