-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dissipation #1244
Dissipation #1244
Conversation
Hi, My opinion would be that if we are providing dissipation, then it should be dissipation. i.e., multiply it by what it needs to be multiplied by. Otherwise we get into a situation like with the jac variable in the code. Which in my opinion is named wrongly. As another note, are you sure you are not missing a 1/2 (or 1/4) scaling somewhere? I typically get the dissipation from the strain rate, which is what I guess you did here, but you write it in a different way that I am not familiar with :) (I am very bad with Einstein notation) |
I guess the scalar eps is what one typically means when one says "dissipation", e.g. a term in the equation for the TKE. But perhaps the tensor is also relevant. |
The dissipation tensor relates to the disspation terms that appear in the transport equations for the individual Reynolds stress components. The scalar dissipation (pseudo-dissipation) is the trace of that tensor. In the end, we should make sure that we have the complete Reynolds stress transport terms in the statistics. For now, I would in fact recommend to just directly compute the TKE dissipation which is the only one needed to compute the isotropic Kolmogorov units. The rest can come later. Regarding the form of the terms, one should clearly include nu (or 1/Re) in it. The factor of two is a bit unclear, as if you do the dissipation for the ui uj terms, you typically do not have the 1/2, but if you do it for TKE, then you do (since TKE is 1/2 u_i u_i). |
Should one have viscosity as a command line argument to the post-processing utility, maybe? Or should it just read the case file? |
Maybe it's better to read it from the case file, because the nu value is not always directly there (if users solve the dimensional eqn then it's mu/rho; if dimensionless then it's 1/Re). |
I could write out another term of scalar epsilon simply as 1/2 of the trace of the tensor (and each term of the tensor is multiplied by 2nu). |
The dissipation is not a free parameter, but directly connected to the simulation. So it should be part of the statistics file. And as such it is not only relevant for dissipation, but for all terms in the various transport equations. Thus my suggestion is to not just focus in this discussion on dissipation, but all relevant terms in the transport equation of TKE, including visous transport, turbulent transport, production etc. |
For computing the lift I added it as a command line argument, but perhaps one could read the json as an argument instead and get it from there. |
In dissipation, we could of course include nu in |
In this PR, dissipation tensor, as a post-processing statistics, is completed with the velocity gradient part. However, the resulting field should be multiplied by 2nu to get the correct tensor, which I am not sure whether should we put it here.$\left<\frac{\partial u_i}{\partial u_k}\frac{\partial u_j}{\partial u_k}\right>$
p.s. the formulation is $\epsilon_{i, j} = 2\nu \left< \frac{\partial u_i}{\partial u_k}\frac{\partial u_j}{\partial u_k}\right>$ and the current output is