"Rework CI for linting and use new linting in main CI" #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Linting is now its own file. - Checks are done for repository and for all changed files individually. - Minimum score can be set when calling the action.
Both develop and main are now set to 8.0 for the repo and individual files. This should be tightened over time.
|
@njansson One note with this one, the branch rules should be modified to include this PR. |
njansson
approved these changes
May 31, 2024
timofeymukha
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes the following changes:
Rework of the CI for linting, including separating linting into its own file, performing checks for the repository and all changed files individually, and adding the ability to set a minimum score when calling the action.
Using the new linting in the main CI workflow.
Clean up of the workflow.
These changes improve the linting process and make it more clear what can be done to improve it.
As an additional bonus, we now cancel old workflows for a PR when a new commit is submitted. which should help reduce resource usage and speedup return for the valid runs.