Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A little change on LES models #1600

Merged
merged 14 commits into from
Jan 12, 2025
Merged

A little change on LES models #1600

merged 14 commits into from
Jan 12, 2025

Conversation

Shiyu-Sandy-Du
Copy link
Collaborator

@Shiyu-Sandy-Du Shiyu-Sandy-Du commented Nov 13, 2024 •
edited
Loading

In this PR, several things are modified regarding LES models:

  1. Another option of the computation of the filter size is available which is based on the average GLL spacing
  2. A little bit change on sigma model
  3. Activate nut computation when restart before time stepping
  4. Add gs operation for nut field

muenschm
muenschm reviewed Nov 18, 2024
View reviewed changes
src/les/les_model.f90 Outdated Show resolved Hide resolved
src/les/bcknd/cpu/sigma_cpu.f90 Outdated Show resolved Hide resolved
src/les/bcknd/device/cuda/sigma_nut_kernel.h Outdated Show resolved Hide resolved
src/les/bcknd/device/hip/sigma_nut_kernel.h Outdated Show resolved Hide resolved
@Shiyu-Sandy-Du
Copy link
Collaborator Author

Seems that we don't have any more opinions on it. Maybe we could merge it. @njansson

@timofeymukha
Copy link
Collaborator

But you didn't merge in my PR to your branch, right?

@timofeymukha
Copy link
Collaborator

Oh wait, this is a different PR, sorry :D

@timofeymukha
Copy link
Collaborator

Sorry that I didn't have time to look at this one. A quick comment would be to rename elementwise_avg to elementwise_average, just to avoid remembering the shortening.

@Shiyu-Sandy-Du Shiyu-Sandy-Du added the enhancement New feature or request label Dec 2, 2024
@timofeymukha timofeymukha merged commit 3a3e144 into ExtremeFLOW:develop Jan 12, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timofeymukha timofeymukha timofeymukha approved these changes

@njansson njansson njansson approved these changes

@muenschm muenschm Awaiting requested review from muenschm

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Neko v1.0.0 release
Status: 🍻 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shiyu-Sandy-Du @timofeymukha @njansson @muenschm