Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tamg #1624

Merged
merged 60 commits into from
Dec 10, 2024
Merged

Feature/tamg #1624

merged 60 commits into from
Dec 10, 2024

Conversation

pohm01
Copy link
Collaborator

@pohm01 pohm01 commented Dec 2, 2024

Add a matrix-free h-multigrid.

Currently only handles piecewise constant interpolation between grid levels.
Chebyshev as a smoother and coarse gird solver.

@pohm01 pohm01 self-assigned this Dec 2, 2024
@timofeymukha
Copy link
Collaborator

Very cool stuff, Peter!

Some quick comments

  • Don't use print, we stick to write
  • You may want to look at the suggestions of the linter under the develop/Flint/List chagend files check. At least sticking to col80 lines would be very nice.
  • This is CPU-only, right? Do we have a check in the code?
  • We should add the tamg to the documentation.
  • Related to the above, when would one use this one as opposed to the hsmg. Is there an example where we could perhaps use it?

Copy link
Collaborator

@njansson njansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial fixes for (C) year (the year should be when the file is added)

src/multigrid/tree_amg.f90 Outdated Show resolved Hide resolved
src/multigrid/tree_amg_aggregate.f90 Outdated Show resolved Hide resolved
src/multigrid/tree_amg_multigrid.f90 Outdated Show resolved Hide resolved
src/multigrid/tree_amg_smoother.f90 Outdated Show resolved Hide resolved
src/multigrid/tree_amg_utils.f90 Outdated Show resolved Hide resolved
src/multigrid/phmg.f90 Outdated Show resolved Hide resolved
@njansson njansson enabled auto-merge December 10, 2024 13:58
@njansson njansson disabled auto-merge December 10, 2024 14:08
@njansson njansson merged commit 3d3e8cf into ExtremeFLOW:develop Dec 10, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🍻 Done
Development

Successfully merging this pull request may close these issues.

3 participants