-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add convergence to the monitor #1625
Add convergence to the monitor #1625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all the checks should be safe false when either is NaN, so it should work. But would be good to get a second opinion on that @pohm01?
Also, before we merge the sx
solvers needed to be modified as well
I added it as a new check instead. So now the solver reports "divergence" under NaN check as before and reports "non-convergence" for the new check.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Mostly an idea regarding the check to make future changes easier.
Adds a convergence flag to the krylov monitor.
Additionally use the flag for throwing an error instead of the nan check.