Comments #3
Open
Comments #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s sprite sheet SpriteSheetLoader
F12-Syntex
requested changes
Jul 2, 2023
There was a problem hiding this comment.
Good job, but some comments have no meaning like the chess pieces class comments
"This is a pawn class that extends chesspiece"
That doesn't really mean anything since a programmer can already see the class name and what it extends, instead talk about what the class will be used for and what it might relate to, for example
This is a class used to represent the attributes of a pawn piece in chess, used by the engine to render pawns onto the board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented on some of the classes.