add offset

FAIRChemistry · Dec 26, 2024 · 9cdb1f2 · 9cdb1f2
1 parent f7cdce5
commit 9cdb1f2
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/src/markdown/parser.rs b/src/markdown/parser.rs
@@ -223,6 +223,10 @@ fn get_position(content: &str, line_offsets: &[usize], start: usize, end: usize)
             start: start_col,
             end: end_col,
         },
+        offset: PositionRange {
+            start: start,
+            end: end,
+        },
     }
 }
 

diff --git a/src/markdown/position.rs b/src/markdown/position.rs
@@ -31,6 +31,7 @@ use pyo3::prelude::*;
 pub struct Position {
     pub line: usize,
     pub column: PositionRange,
+    pub offset: PositionRange,
 }
 
 impl PartialOrd for Position {

diff --git a/src/validation.rs b/src/validation.rs
@@ -427,6 +427,25 @@ impl Validator {
     ) {
         let attribute_positions = extract_attribute_positions(object);
 
+        if dtype.is_empty() {
+            self.add_error(ValidationError {
+                message: format!(
+                    "Property '{}' has no type defined. Either define a type or use a base type.",
+                    attribute.name
+                ),
+                object: Some(object.name.clone()),
+                attribute: Some(attribute.name.clone()),
+                location: "Global".into(),
+                error_type: ErrorType::TypeError,
+                positions: attribute_positions
+                    .get(&attribute.name)
+                    .cloned()
+                    .unwrap_or_default(),
+            });
+
+            return;
+        }
+
         if !types.contains(&dtype) && !BASIC_TYPES.contains(&dtype) {
             self.add_error(ValidationError {
                 message: format!(