refactor from_str to fix irrefutable if let

FAIRChemistry · Oct 22, 2024 · ad3492a · ad3492a
1 parent fe5c61b
commit ad3492a
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/attribute.rs b/src/attribute.rs
@@ -226,13 +226,15 @@ impl FromStr for DataType {
 
     /// Converts a string to a DataType (Boolean, Integer, Float, or String).
     fn from_str(s: &str) -> Result<Self, Self::Err> {
-        if let Ok(b) = s.to_lowercase().parse::<bool>() {
+        let lower_s = s.to_lowercase();
+
+        if let Ok(b) = lower_s.parse::<bool>() {
             Ok(DataType::Boolean(b))
-        } else if let Ok(i) = s.to_lowercase().parse::<i64>() {
+        } else if let Ok(i) = lower_s.parse::<i64>() {
             Ok(DataType::Integer(i))
-        } else if let Ok(f) = s.to_lowercase().parse::<f64>() {
+        } else if let Ok(f) = lower_s.parse::<f64>() {
             Ok(DataType::Float(f))
-        } else if let Ok(s) = s.to_lowercase().parse::<String>() {
+        } else if !lower_s.is_empty() {
             Ok(DataType::String(format!("\"{}\"", s)))
         } else {
             Err("Invalid data type".to_string())